refactor: Change the inner structure of DateTime
#267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorairolake
force-pushed
the
change-datetime-inner-structure
branch
4 times, most recently
from
9f3845f to
06d31e0
Compare
Hold the values as packed date and packed time. Note that the second resolution is changed to 2 seconds.
sorairolake
force-pushed
the
change-datetime-inner-structure
branch
from
06d31e0 to
9f4d1b8
Compare
Pr0methean
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hold the values as packed date and packed time. This is the same as MS-DOS date and time which is the time representation in ZIP. Note that the second resolution is changed to 2 seconds.
This change reduces the size of
DateTimefrom 8 bytes to 4 bytes.mem::size_ofmem::align_of